Repository navigation
Throw a 400 Bad Request error instead of 500 on decoding failure - #11
Merged
Merged
Conversation
| public var message: String { | ||
| switch self { | ||
| case let .decodingFailed(error): | ||
| "Invalid request body: \(error)" |
Collaborator
There was a problem hiding this comment.
I don't think we should send back an actual decoding error here. While it might be helpful in debug mode something generic like
{ "error": "invalid_request", "message": "The request body could not be decoded." } would be more suited for a prod response.
John-Connolly
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently a bad POST body sent into a LambdaKit Router will return a 500 Internal Server Error. After this PR it will return a 400 Bad Request containing the error message from the JSONDecoder. This PR also writes some simple tests for the Router to document this behavior. I verified that the test fails without the new error throw and passes with the code included. To make tests and other basic code more simple to write, more overloads have been introduced to allow making a POST with a body without passing middleware through. I also split the errors up into their own files in their own directory